Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft post on retirement policy #714

Merged
merged 3 commits into from
Feb 19, 2018
Merged

draft post on retirement policy #714

merged 3 commits into from
Feb 19, 2018

Conversation

mdlincoln
Copy link
Contributor

Comments and improvements welcomed!

Closes #713

@acrymble
Copy link

Thanks Matt. The only thing I would flag is the use of "PH" instead of 'Programming Historian' in a few of the new files. I don't think we use that acronym formally.

This is great work. Thanks to everyone involved.

@mdlincoln
Copy link
Contributor Author

Thanks @acrymble - could you please click on the "Add your review" link below, next to the red "Review required" alert, select "Approve" and then click "Submit review"?

@walshbr walshbr mentioned this pull request Feb 19, 2018
8 tasks
Copy link

@acrymble acrymble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt. The only thing I would flag is the use of "PH" instead of 'Programming Historian' in a few of the new files. I don't think we use that acronym formally.

This is great work. Thanks to everyone involved.

Copy link

@acrymble acrymble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes affect other files, not this one:

@mdlincoln mdlincoln merged commit f75473e into gh-pages Feb 19, 2018
@mdlincoln mdlincoln deleted the retirement-blog-post branch March 7, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants